-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Distinguish between insecure and tis-verify #98
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be exposed from the oras/client.py as well? And don't forget to add a note to the CHANGELOG.md and bump the version in oras/version.py
Yes, there is a different between a registry listening with plain http and listening on https with https but not a valid Crt. |
I think you missed my question about the client - could we please expose the parameter here along with insecure? Line 32 in 0f331fb
|
…of registry) Signed-off-by: Marius Bertram <[email protected]>
Signed-off-by: Marius Bertram <[email protected]>
Signed-off-by: Marius Bertram <[email protected]>
Signed-off-by: Marius Bertram <[email protected]>
Signed-off-by: Marius Bertram <[email protected]>
The docker client will skip the tis verification if tis_verify is set. On Plain http registries tis_verify has no effect. |
Co-authored-by: Vanessasaurus <[email protected]> Signed-off-by: Marius Bertram <[email protected]>
The insecure option for oras.registry sets the transport protocol. The default behaviour of other projects which interact with registries (ores-cli, podman,....), differenciate between transport protocol and trust for connections to registries.
To avoid breaking changes, the parameter
insecure
sets the transport protocol ans the new parametertls_verify
sets verification on CA Trust.